Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On restore, selecting concrete indices can select wrong index #17715

Merged
merged 1 commit into from Apr 13, 2016

Conversation

Projects
None yet
2 participants
@seut
Copy link
Contributor

commented Apr 13, 2016

While restoring a snapshot with multiple indices inside, selecting concrete indices can result in a wrong index being restored. This happens if at least 1 selected index is not available inside the snapshot while another being available but not the first one at the available list.

Example:

  • Available indices in snapshot: ["foo", "bar" baz"]
  • Selected indices to restore: ["bar", "not_available"]
  • Resulting indices to be restored: ["foo"] <-- WRONG, expected ["bar"]

This bug was also verified to appear at 1.7 and 2.x.

@ywelsch ywelsch changed the title On restore, selecting indices can select wrong index On restore, selecting concrete indices can select wrong index Apr 13, 2016

@ywelsch

This comment has been minimized.

Copy link
Contributor

commented Apr 13, 2016

@seut LGTM. Thanks for contributing. I will also backport this to 2.3.2 (see version labels on the PR). Backports to 1.7 are only for the most critical bugs.

@ywelsch ywelsch merged commit 0b889f1 into elastic:master Apr 13, 2016

1 check passed

CLA Commit author has signed the CLA
Details

@ywelsch ywelsch added the v2.4.0 label Apr 13, 2016

ywelsch added a commit that referenced this pull request Apr 13, 2016

ywelsch added a commit that referenced this pull request Apr 13, 2016

@seut seut deleted the crate:s/fix-restore-filter-indices branch Apr 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.