Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shard level tasks in Bulk Action lose reference to their parent tasks #17743

Merged
merged 1 commit into from Apr 15, 2016

Conversation

Projects
None yet
2 participants
@imotov
Copy link
Member

commented Apr 14, 2016

During the bulk action a hierachy of tasks is getting created: bulk->bulk[s](coord node) -> bulk[s](primary shard node) -> bulk[s][p] and bulk[s][r]. Due to a bug the first bulk[s] task didn't have bulk's task id is set as a parent id. This commit fixes this bug.

}

@Override
protected void doExecute(Task task, BulkRequest bulkRequest, ActionListener<BulkResponse> listener) {

This comment has been minimized.

Copy link
@dakrone

dakrone Apr 14, 2016

Member

Can we make these final like the previous doExecute method?

@dakrone

This comment has been minimized.

Copy link
Member

commented Apr 14, 2016

Left one comment, other than that, LGTM

Shard level tasks in Bulk Action lose reference to their parent tasks
During the bulk action a hierachy of tasks is getting created: bulk->bulk[s] (coord node) -> bulk[s] (primary shard node) -> bulk[s][p] and bulk[s][r]. Due to a bug the first bulk[s] task didn't have bulk's task id is set as a parent id.  This commit fixes this bug.

@imotov imotov force-pushed the imotov:bulk-tasks-lose-parent-task-ids branch to f030796 Apr 15, 2016

@imotov imotov merged commit f030796 into elastic:master Apr 15, 2016

1 check passed

CLA Commit author is a member of Elasticsearch
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.