New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't try to compute completion stats on a reader after we already closed it #18094
Conversation
+1 |
LGTM. |
Looks like the bug first appeared in 2.3.0. |
Don't try to compute completion stats on a reader after we already closed it
Don't try to compute completion stats on a reader after we already closed it Conflicts: core/src/main/java/org/elasticsearch/index/shard/IndexShard.java
@mikemccand @jasontedor - What is the impact of this fix if we are not using
The exception is like below
We are using 2.3.1 and in the process of upgrading to the latest 6. I know we are using a very old version of ES. This exceptions we started seeing in our production deployment. It will be helpful if you can provide some insight whether it needs serious attention. |
This can cause
AlreadyClosedException
and can also crash your JVM ifmmapfs
is in use and Lucene's best-effort check to catch this illegal usage fails, in 2.3.2.I'll also fix this in 5.0.0, but there the bug is more harmless (computes stats twice, but without causing ACE/possible JVM crash).