Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow CORS requests to work with HTTP compression enabled #18101

Merged

Conversation

Projects
None yet
2 participants
@danielmitterdorfer
Copy link
Member

commented May 3, 2016

With this commit we fix an issue that prevented to turn on
HTTP compression when using CORS. The problem boiled down
to a problematic order of the respective handlers in
Netty's pipeline.

Note that the same problem is already fixed in ES 5.0 by #18066.

Relates #18066
Fixes #18089

Allow CORS requests to work with HTTP compression enabled
With this commit we fix an issue that prevented to turn on
HTTP compression when using CORS. The problem boiled down
to a problematic order of the respective handlers in
Netty's pipeline.

Note that the same problem is already fixed in ES 5.0 by

Relates #18066
Fixes #18089
@dadoonet

This comment has been minimized.

Copy link
Member

commented May 3, 2016

LGTM

@dadoonet dadoonet removed the review label May 3, 2016

@danielmitterdorfer

This comment has been minimized.

Copy link
Member Author

commented May 3, 2016

@dadoonet thanks for the review!

@danielmitterdorfer danielmitterdorfer merged commit 9b471da into elastic:2.x May 3, 2016

1 check passed

CLA Commit author has signed the CLA
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.