Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long priority over Float #18282

Merged
merged 2 commits into from May 12, 2016

Conversation

Projects
None yet
4 participants
@jdconrad
Copy link
Contributor

commented May 11, 2016

Def math operations will now check for Long before Float. Note that type promotion still works correctly because we make sure both ops are Long. (This does require an extra branch in some cases, but I believe the trade off is worth it as Float should be a very rarely used type.)

@rjernst

This comment has been minimized.

Copy link
Member

commented May 11, 2016

LGTM

@rmuir

This comment has been minimized.

Copy link
Contributor

commented May 11, 2016

maybe we can be a little more conservative and reorder only where it won't cost us an additional branch?

I think its helpful to keep the cases minimal too in case we implement them differently (e.g. methodhandle).

@rmuir

This comment has been minimized.

Copy link
Contributor

commented May 11, 2016

+1

@jdconrad jdconrad merged commit 8871fdd into elastic:master May 12, 2016

1 check passed

CLA Commit author is a member of Elasticsearch
Details

@jdconrad jdconrad deleted the jdconrad:longs branch May 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.