Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the dynamic call site factory to DefBootstrap #18335

Merged
merged 1 commit into from May 13, 2016

Conversation

Projects
None yet
3 participants
@uschindler
Copy link
Contributor

commented May 13, 2016

... and make the inner class name very short (PIC = Polymorphic Inline Cache)

The reason for this change is to make stack traces look nice if the bootstrapping of invokedynamic fails. The current class names were inconsistent and redundant. PIC (Polymorphic Inline Cache) is just an internal impl detail and the name was choosen to be short.

painless: Rename the dynamic call site factory to DefBootstrap and ma…
…ke the inner class very short (PIC = Polymorphic Inline Cache)
@rmuir

This comment has been minimized.

Copy link
Contributor

commented May 13, 2016

Looks good. The shorter name will give less noise in errors, and the bootstrap name is less confusing (its no callsite).

@rmuir rmuir merged commit f2cc848 into elastic:master May 13, 2016

1 check passed

CLA Commit author has signed the CLA
Details
@rmuir

This comment has been minimized.

Copy link
Contributor

commented May 13, 2016

Thanks @uschindler for these cleanups!

@uschindler uschindler deleted the uschindler:painless_bootsrap_renames branch May 13, 2016

@clintongormley clintongormley changed the title painless: Rename the dynamic call site factory to DefBootstrap Rename the dynamic call site factory to DefBootstrap May 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.