Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GC overhead logging #18419

Merged
merged 3 commits into from May 18, 2016

Conversation

Projects
None yet
3 participants
@jasontedor
Copy link
Member

commented May 17, 2016

This commit adds simple GC overhead logging. This logging captures
intervals where the JVM is spending a lot of time performing GC but it
is not necessarily the case that each GC is large. For a start, this
logging is simple and does not attempt to incorporate whether or not the
collections were efficient (that is, we are only capturing that a lot of
GC is happening, not that a lot of useless GC is happening).

@jasontedor

This comment has been minimized.

Copy link
Member Author

commented May 17, 2016

This produces logging like

[2016-05-17 14:32:52,240][INFO][monitor.jvm              ] [Novs] [gc][3] overhead, spent [350ms] collecting in the last [1s]
Add GC overhead logging
This commit adds simple GC overhead logging. This logging captures
intervals where the JVM is spending a lot of time performing GC but it
is not necessarily the case that each GC is large. For a start, this
logging is simple and does not attempt to incorporate whether or not the
collections were efficient (that is, we are only capturing that a lot of
GC is happening, not that a lot of useless GC is happening).
@nik9000

This comment has been minimized.

Copy link
Contributor

commented May 18, 2016

LGTM but it is probably worth another set of eyes because it is late.

jasontedor added some commits May 18, 2016

Add assertion that test assertions were invoked
Because the test assertions for the JvmMonitorTests#testMonitorGc sit
inside a callback, this commit adds an assertions that these assertions
were actually tripped otherwise they could be silently excluded.
Fix formatting in JvmGcMonitorService.java
This commit addresses a few indentation issues in the source file for
JvmGcMonitorService.

@jasontedor jasontedor merged commit cad0608 into elastic:master May 18, 2016

1 check passed

CLA Commit author is a member of Elasticsearch
Details

@jasontedor jasontedor deleted the jasontedor:gc-overhead branch May 18, 2016

@jasontedor jasontedor removed the review label May 18, 2016

@small-tomorrow

This comment has been minimized.

Copy link

commented Nov 30, 2016

This problem troubled me so much ,when upgrading from ES 2.1 to ES 5.0 , bulk requests keep making OOM , looking forward to your help here's the discuss : https://discuss.elastic.co/t/did-i-get-to-the-upper-limit-of-bulk-upload-api/66620/3

@small-tomorrow

This comment has been minimized.

Copy link

commented Nov 30, 2016

the log keeps printing :
[2016-11-30T13:56:11,860][INFO ][o.e.m.j.JvmGcMonitorService] [es-nmg02-jpaas212] [gc][10] overhead, spent [316ms] collecting in the last [1s] [2016-11-30T13:56:15,862][INFO ][o.e.m.j.JvmGcMonitorService] [es-nmg02-jpaas212] [gc][14] overhead, spent [278ms] collecting in the last [1s] [2016-11-30T13:56:29,071][INFO ][o.e.m.j.JvmGcMonitorService] [es-nmg02-jpaas212] [gc][27] overhead, spent [283ms] collecting in the last [1s]
...
and finally OOM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.