fixed always returning 1 if launching in background without pidpath #1883

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

sfussenegger commented Apr 24, 2012

Currently, the returned value depends on this line:

[ ! -z "$pidpath" ] && printf '%d' $! > "$pidpath"

rather than

exec "$JAVA" ...

which is just before. This certainly isn't intended as a successful start (script returning 0) shouldn't depend on the creation of a PID file.

Owner

kimchy commented Apr 24, 2012

Pushed to master and 0.19 branch, thanks!

@kimchy kimchy closed this Apr 24, 2012

bleskes pushed a commit to bleskes/elasticsearch that referenced this pull request Nov 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment