Beef up Translog testing with random channel exceptions #18997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today we only throw random exceptions on the translog writer. This commit extends it to also throw exceptions during checkpoint writing etc to test if the correct flags are provided to open method etc.
s1monw
added
>enhancement
>test
| instance = creator.get(); | ||
| System.out.println("------------ " + instance.getClass()); |
|
Makes sense to me. |
| @@ -200,7 +200,7 @@ public Translog(TranslogConfig config, TranslogGeneration translogGeneration) th | |||
| Files.createDirectories(location); | |||
| final long generation = 1; | |||
| Checkpoint checkpoint = new Checkpoint(0, 0, generation); | |||
| Checkpoint.write(location.resolve(CHECKPOINT_FILE_NAME), checkpoint, StandardOpenOption.WRITE, StandardOpenOption.CREATE_NEW); | |||
| Checkpoint.write(getChannelFactory()::open, location.resolve(CHECKPOINT_FILE_NAME), checkpoint, StandardOpenOption.WRITE, StandardOpenOption.CREATE_NEW); | |||
There was a problem hiding this comment.
nit: we don't need the open method reference.
|
LGTM. Left a minor suggestion. Happy no failure came out of this. |
| @@ -56,6 +56,7 @@ public T get() { | |||
| */ | |||
| synchronized (InjectorImpl.class) { | |||
| if (instance == null) { | |||
|
|
|||
|
I like it too, and agree with @bleskes suggestion. |
clintongormley
added
:Distributed/Distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we only throw random exceptions on the translog writer. This commit
extends it to also throw exceptions during checkpoint writing etc to test
if the correct flags are provided to open method etc.