New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc values support to the _size field in the mapper-size plugin #19217

Merged
merged 1 commit into from Jul 5, 2016

Conversation

Projects
None yet
4 participants
@jimczi
Member

jimczi commented Jul 1, 2016

This change activates the doc_values on the _size field for indices created after 5.0.0-alpha4.
It also adds a note in the breaking changes that explain the situation and how to get around it.

Closes #18334

@nik9000

View changes

Show outdated Hide outdated ...e/src/main/java/org/elasticsearch/index/mapper/size/SizeFieldMapper.java
@nik9000

This comment has been minimized.

Show comment
Hide comment
@nik9000

nik9000 Jul 1, 2016

Contributor

It looks like you fixed some line length violations so maybe you should remove lines from checkstyle_suppressions.xml?

Contributor

nik9000 commented Jul 1, 2016

It looks like you fixed some line length violations so maybe you should remove lines from checkstyle_suppressions.xml?

@jpountz

View changes

Show outdated Hide outdated docs/plugins/mapper-size.asciidoc
@jpountz

View changes

Show outdated Hide outdated docs/plugins/mapper-size.asciidoc
@jpountz

View changes

Show outdated Hide outdated docs/reference/migration/migrate_5_0/plugins.asciidoc
@jpountz

This comment has been minimized.

Show comment
Hide comment
@jpountz

jpountz Jul 1, 2016

Contributor

LGTM, let's just do the version bump before merging it?

Contributor

jpountz commented Jul 1, 2016

LGTM, let's just do the version bump before merging it?

@jimczi

This comment has been minimized.

Show comment
Hide comment
@jimczi

jimczi Jul 5, 2016

Member

Thanks @nik9000 and @jpountz.
I'll merge after #19250

Member

jimczi commented Jul 5, 2016

Thanks @nik9000 and @jpountz.
I'll merge after #19250

Add doc values support to the _size field in the mapper-size plugin
This change activates the doc_values on the _size field for indices created after 5.0.0-alpha4.
It also adds a note in the breaking changes that explain the situation and how to get around it.

Closes #18334

@jimczi jimczi merged commit 44badf5 into elastic:master Jul 5, 2016

1 check passed

CLA Commit author is a member of Elasticsearch
Details

@jimczi jimczi deleted the jimczi:mapper_size_docvalues2 branch Jul 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment