New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate the cardinality, scripted_metric, and geo_centroid aggregations to NamedWriteable #19219

Merged
merged 1 commit into from Jul 4, 2016

Conversation

Projects
None yet
2 participants
@nik9000
Contributor

nik9000 commented Jul 1, 2016

This is the last of the remaining "calc" aggregations.

Once all of these are migrated we'll be able to remove aggregation's custom "streams" which function that same as NamedWriteable. It also allows us to make most of the fields on aggregations final which is rather nice.

@nik9000

This comment has been minimized.

Show comment
Hide comment
@nik9000

nik9000 Jul 1, 2016

Contributor

@colings86 another one for you.

Contributor

nik9000 commented Jul 1, 2016

@colings86 another one for you.

@colings86

This comment has been minimized.

Show comment
Hide comment
@colings86

colings86 Jul 4, 2016

Member

LGTM

Member

colings86 commented Jul 4, 2016

LGTM

Migrate remaining calc aggs to NamedWriteable
Once all of these are migrated we'll be able to remove aggregation's
custom "streams" which function that same as NamedWriteable. It also
allows us to make most of the fields on aggregations final which is
rather nice.

@nik9000 nik9000 merged commit c02de92 into elastic:master Jul 4, 2016

1 check passed

CLA Commit author has signed the CLA
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment