New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify TcpTransport interface by reducing send code to a single send method #19223

Merged
merged 13 commits into from Jul 5, 2016

Conversation

Projects
None yet
2 participants
@s1monw
Contributor

s1monw commented Jul 1, 2016

Due to some optimization on the netty layer we had quite some code / cruft
added to the TcpTransport to allow for those optimizations. After cleaning
up BytesReference we can now move this optimization into TcpTransport and
have a simple send method on the implementation layer instead. This commit
adds a CompositeBytesReference that also allows message headers to be written
separately which simplify the header code as well since no skips are needed
anymore.

@s1monw

This comment has been minimized.

Show comment
Hide comment
@s1monw

s1monw Jul 1, 2016

Contributor

@jasontedor can you take a look

Contributor

s1monw commented Jul 1, 2016

@jasontedor can you take a look

@jasontedor

View changes

Show outdated Hide outdated ...rc/main/java/org/elasticsearch/common/bytes/CompositeBytesReference.java
@jasontedor

View changes

Show outdated Hide outdated ...rc/main/java/org/elasticsearch/common/bytes/CompositeBytesReference.java
@jasontedor

View changes

Show outdated Hide outdated ...rc/main/java/org/elasticsearch/common/bytes/CompositeBytesReference.java
@jasontedor

View changes

Show outdated Hide outdated ...st/java/org/elasticsearch/common/bytes/CompositeBytesReferenceTests.java
@jasontedor

View changes

Show outdated Hide outdated ...st/java/org/elasticsearch/common/bytes/CompositeBytesReferenceTests.java
@jasontedor

This comment has been minimized.

Show comment
Hide comment
@jasontedor

jasontedor Jul 4, 2016

Member

It looks good @s1monw; I left some minor comments.

Member

jasontedor commented Jul 4, 2016

It looks good @s1monw; I left some minor comments.

@s1monw

This comment has been minimized.

Show comment
Hide comment
@s1monw

s1monw Jul 4, 2016

Contributor

@jasontedor I pushed updates

Contributor

s1monw commented Jul 4, 2016

@jasontedor I pushed updates

@jasontedor

View changes

Show outdated Hide outdated core/src/test/java/org/elasticsearch/cluster/MinimumMasterNodesIT.java
@jasontedor

View changes

Show outdated Hide outdated .../java/org/elasticsearch/common/bytes/AbstractBytesReferenceTestCase.java
@jasontedor

This comment has been minimized.

Show comment
Hide comment
@jasontedor

jasontedor Jul 4, 2016

Member

It still looks good, I left a couple more minor comments.

Member

jasontedor commented Jul 4, 2016

It still looks good, I left a couple more minor comments.

s1monw added some commits Jul 1, 2016

Simplify TcpTransport interface by reducing send code to a single sen…
…d method

Due to some optimization on the netty layer we hade quite some code / cruft
added to the TcpTransport to allow for those optimizations. After cleaning
up BytesReference we can now move this optimization into TcpTransport and
have a simple send method on the implemenation layer instead. This commit
adds a CompositeBytesReference that also allows message headers to be written
seperately which simplify the header code as well since no skips are needed
anymore.

@s1monw s1monw merged commit 44ccf67 into elastic:master Jul 5, 2016

1 check passed

CLA Commit author is a member of Elasticsearch
Details

@s1monw s1monw deleted the s1monw:unoptimize_netty branch Jul 5, 2016

jasontedor added a commit that referenced this pull request Jul 6, 2016

Merge branch 'master' into feature/seq_no
* master: (192 commits)
  [TEST] Fix rare OBOE in AbstractBytesReferenceTestCase
  Reindex from remote
  Rename writeThrowable to writeException
  Start transport client round-robin randomly
  Reword Refresh API reference (#19270)
  Update fielddata.asciidoc
  Fix stored_fields message
  Add missing footer notes in mapper size docs
  Remote BucketStreams
  Add doc values support to the _size field in the mapper-size plugin
  Bump version to 5.0.0-alpha5.
  Update refresh.asciidoc
  Update shrink-index.asciidoc
  Change Debian repository for Vagrant debian-8 box
  [TEST] fix test to account for internal empyt reference optimization
  Upgrade to netty 3.10.6.Final (#19235)
  [TEST] fix histogram test when extended bounds overlaps data
  Remove redundant modifier
  Simplify TcpTransport interface by reducing send code to a single send method (#19223)
  Fix style violation in InstallPluginCommand.java
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment