Add blocking socket based MockTcpTransport #19332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1monw
added
>test
| if (e.getMessage().contains("Connection reset by peer")) { | ||
| return true; | ||
| } | ||
| if (e.getMessage().contains("Connection reset")) { |
There was a problem hiding this comment.
Can you just remove the "by peer" from the first, since matching this new case is a superset of matching the first case?
|
This looks great! I left a few small comments, LGTM as is though except for the question about commented out code. |
|
@rjernst I pushed a new commit |
|
LGTM |
s1monw
force-pushed
the
add_mock_network_transport
branch
from
08e35b5
to
50d1a4b
Compare
Today we have a bunch of tests that use netty transport for several reasons these tests use it because they need to run some tcp based trasnport. Yet, this couples our tests tightly to the netty implementation which should be tested on it's own. This change adds a plain socket based blocking TcpTransport implementation that is used by default in tests if local transport is suppressed or if network is selected. It also adds another tcp network implementation as a showcase how the interface works.
s1monw
force-pushed
the
add_mock_network_transport
branch
from
50d1a4b
to
8f7c41e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we have a bunch of tests that use netty transport for several reasons
these tests use it because they need to run some tcp based transport. Yet, this
couples our tests tightly to the netty implementation which should be tested on it's own.
This change adds a plain socket based blocking TcpTransport implementation that is used by
default in tests if local transport is suppressed or if network is selected.
It also adds another tcp network implementation as a showcase how the interface works.