New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let fast vector highlighter also extract terms from the nested query's inner query. #19337

Merged
merged 1 commit into from Jul 13, 2016

Conversation

Projects
None yet
3 participants
@martijnvg
Member

martijnvg commented Jul 8, 2016

PR for #19265

@nik9000 nik9000 changed the title from Let fact vector highlighter also extract terms from the nested query's inner query. to Let fast vector highlighter also extract terms from the nested query's inner query. Jul 8, 2016

@nik9000

This comment has been minimized.

Show comment
Hide comment
@nik9000

nik9000 Jul 8, 2016

Contributor

I don't know the ToParentBlockJoinQuery at all but this is how I'd hack support for it into the FVH. I might try to open a Lucene issue to get it in instead/in addition, but otherwise LGTM.

Contributor

nik9000 commented Jul 8, 2016

I don't know the ToParentBlockJoinQuery at all but this is how I'd hack support for it into the FVH. I might try to open a Lucene issue to get it in instead/in addition, but otherwise LGTM.

@jpountz

This comment has been minimized.

Show comment
Hide comment
@jpountz

jpountz Jul 8, 2016

Contributor

+1 to the Lucene issue and LGTM to this one

Contributor

jpountz commented Jul 8, 2016

+1 to the Lucene issue and LGTM to this one

@martijnvg

This comment has been minimized.

Show comment
Hide comment
@martijnvg

martijnvg Jul 9, 2016

Member

@nik9000 @jpountz I'll open an issue in Lucene. I initially thought that the highlighter module didn't depend on the join module, but I was wrong, it does!

Member

martijnvg commented Jul 9, 2016

@nik9000 @jpountz I'll open an issue in Lucene. I initially thought that the highlighter module didn't depend on the join module, but I was wrong, it does!

@martijnvg martijnvg merged commit 2bdc55c into elastic:master Jul 13, 2016

1 check passed

CLA Commit author is a member of Elasticsearch
Details
@martijnvg

This comment has been minimized.

Show comment
Hide comment
@martijnvg
Member

martijnvg commented Jul 13, 2016

The Lucene issue for referencing: https://issues.apache.org/jira/browse/LUCENE-7376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment