GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR for #19265
I don't know the ToParentBlockJoinQuery at all but this is how I'd hack support for it into the FVH. I might try to open a Lucene issue to get it in instead/in addition, but otherwise LGTM.
+1 to the Lucene issue and LGTM to this one
@nik9000 @jpountz I'll open an issue in Lucene. I initially thought that the highlighter module didn't depend on the join module, but I was wrong, it does!
fvh: Also extract terms from the nested query' inner query.
The Lucene issue for referencing: https://issues.apache.org/jira/browse/LUCENE-7376