New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove child injectors from guice #19346

Merged
merged 1 commit into from Jul 9, 2016

Conversation

Projects
None yet
2 participants
@rjernst
Member

rjernst commented Jul 8, 2016

This change removes the ability for guice to have child injectors (and
the entire concept of parent injectors) from our fork of guice. The
methodology for removing was simple: I removed createChildInjector, and
continued to remove methods and members that were unused until my head
was spinning. The motivation for this change is to limit what our fork
of guice gives us access to, so we don't regress and start adding back
more complicated uses.

Internal: Remove child injectors from guice
This change removes the ability for guice to have child injectors (and
the entire concept of parent injectors) from our fork of guice. The
methodology for removing was simple: I removed createChildInjector, and
continued to remove methods and members that were unused until my head
was spinning. The motivation for this change is to limit what our fork
of guice gives us access to, so we don't regress and start adding back
more complicated uses.
@s1monw

This comment has been minimized.

Show comment
Hide comment
@s1monw

s1monw Jul 9, 2016

Contributor

I didn't even look - trash it

Contributor

s1monw commented Jul 9, 2016

I didn't even look - trash it

@rjernst rjernst merged commit 03bd152 into elastic:master Jul 9, 2016

1 check passed

CLA Commit author is a member of Elasticsearch
Details

@rjernst rjernst deleted the rjernst:deguice_guice branch Jul 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment