-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes index creation more friendly #19450
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, index creation would momentarily cause the cluster health to go RED, because the primaries were still being assigned and activated. This commit ensures that when an index is created or an index is being recovered during cluster recovery and it does not have any active allocation ids, then the cluster health status will not go RED, but instead be YELLOW. Relates #9126
If the allocation decision for a primary shard was NO, this should cause the cluster health for the shard to go RED, even if the shard belongs to a newly created index or is part of cluster recovery. Relates #9126
Before returning, index creation now waits for the configured number of shard copies to be started. In the past, a client would create an index and then potentially have to check the cluster health to wait to execute write operations. With the cluster health semantics changing so that index creation does not cause the cluster health to go RED, this change enables waiting for the desired number of active shards to be active before returning from index creation. Relates #9126
abeyad
added
>enhancement
resiliency
:Cluster
v5.0.0-alpha5
:Core/Infra/Core
Core issues without another label
and removed
:Cluster
labels
Jul 15, 2016
3 tasks
Very awesome! |
abeyad
pushed a commit
to abeyad/elasticsearch
that referenced
this pull request
Jul 15, 2016
integration tests, as they are no longer needed with index creation now waiting for shards to be started before returning from the index creation call (by default, it waits for the primary of each shard to be started before returning, which is what ensureYellow() was ensuring anyway). Closes elastic#19452 Relates elastic#19450
abeyad
pushed a commit
that referenced
this pull request
Jul 15, 2016
integration tests, as they are no longer needed with index creation now waiting for shards to be started before returning from the index creation call (by default, it waits for the primary of each shard to be started before returning, which is what ensureYellow() was ensuring anyway). Closes #19452 Relates #19450
abeyad
pushed a commit
to abeyad/elasticsearch
that referenced
this pull request
Jul 15, 2016
creation in the REST tests, as we no longer need it due to index creation now waiting for active shard copies before returning (by default, it waits for the primary of each shard, which is the same as ensuring yellow health). Relates elastic#19450
abeyad
pushed a commit
that referenced
this pull request
Jul 15, 2016
creation in the REST tests, as we no longer need it due to index creation now waiting for active shard copies before returning (by default, it waits for the primary of each shard, which is the same as ensuring yellow health). Relates #19450
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two major features, described in their respective PRs below:
RED
(rather it just goes toYELLOW
). This greatly helps administrators of Elasticsearch clusters who get alerted whenever the cluster health goesRED
.YELLOW
instead ofRED
, this PR also enables waiting for a certain number of shard copies to be started before returning from the index creation operation.This PR encompasses two other PRs:
Closes #9126