Version bump AWS SDK 1.11.18 #19489

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
5 participants
@nl5887

nl5887 commented Jul 18, 2016

  • bump version
  • fixed issue with double md5 signature generation

nl5887 added some commits Jul 18, 2016

removed double md5 signature
md5 hash was being generated twice, once in aws sdk code, once in
DefaultS3OutputStream.
@nl5887

This comment has been minimized.

Show comment
Hide comment
@nl5887

nl5887 Jul 18, 2016

the repository-s3 plugin is throwing an error in the unit tests. This has probably to do with the security policy, suggestions on how to solve are appreciated.

Throwable #1: java.lang.AssertionError: expected [2xx] status code but api [snapshot.create_repository] returned [500 Internal Server Error] [{"error":{"root_cause":[{"type":"repository_exception","reason":"[test_repo_s3_1] failed to create repository"}],"type":"repository_exception","reason":"[test_repo_s3_1] failed to create repository","caused_by":{"type":"access_control_exception","reason":"access denied ("java.lang.RuntimePermission" "accessDeclaredMembers")"}},"status":500}]

nl5887 commented Jul 18, 2016

the repository-s3 plugin is throwing an error in the unit tests. This has probably to do with the security policy, suggestions on how to solve are appreciated.

Throwable #1: java.lang.AssertionError: expected [2xx] status code but api [snapshot.create_repository] returned [500 Internal Server Error] [{"error":{"root_cause":[{"type":"repository_exception","reason":"[test_repo_s3_1] failed to create repository"}],"type":"repository_exception","reason":"[test_repo_s3_1] failed to create repository","caused_by":{"type":"access_control_exception","reason":"access denied ("java.lang.RuntimePermission" "accessDeclaredMembers")"}},"status":500}]

@nik9000

This comment has been minimized.

Show comment
Hide comment
@nik9000

nik9000 Jul 19, 2016

Contributor

Yeah, that looks like a security exception. The plugin already has that permission but, I expect, there is so new access pattern for it now. You'll have to track that down and wrap it in AccessController.doPrivileged.

Contributor

nik9000 commented Jul 19, 2016

Yeah, that looks like a security exception. The plugin already has that permission but, I expect, there is so new access pattern for it now. You'll have to track that down and wrap it in AccessController.doPrivileged.

@nik9000

This comment has been minimized.

Show comment
Hide comment
@nik9000

nik9000 Jul 19, 2016

Contributor

Maybe @tlrx should review this? I don't know that AWS stuff well.

Contributor

nik9000 commented Jul 19, 2016

Maybe @tlrx should review this? I don't know that AWS stuff well.

@dadoonet

This comment has been minimized.

Show comment
Hide comment
@dadoonet

dadoonet Jul 26, 2016

Member

Hi @nl5887.

I'm sorry I did not see your PR before I started working on #19594 (upgrade to 1.11.20).

So I just cherry-picked your commit 9fd0d62 in my PR.

The PR I started has also some modifications in docs and tests as a default value of the AWS SDK has changed (throttle retries).
Also in 1.11.20 some (a lot of) methods now returns an Object instead of void.

I think we should close your PR and work in #19594 now.

Member

dadoonet commented Jul 26, 2016

Hi @nl5887.

I'm sorry I did not see your PR before I started working on #19594 (upgrade to 1.11.20).

So I just cherry-picked your commit 9fd0d62 in my PR.

The PR I started has also some modifications in docs and tests as a default value of the AWS SDK has changed (throttle retries).
Also in 1.11.20 some (a lot of) methods now returns an Object instead of void.

I think we should close your PR and work in #19594 now.

@elasticmachine

This comment has been minimized.

Show comment
Hide comment
@elasticmachine

elasticmachine Jul 26, 2016

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@clintongormley

This comment has been minimized.

Show comment
Hide comment
@clintongormley

clintongormley Jul 27, 2016

Member

Closing in favor of #19594

Member

clintongormley commented Jul 27, 2016

Closing in favor of #19594

@nl5887

This comment has been minimized.

Show comment
Hide comment
@nl5887

nl5887 Jul 28, 2016

@dadoonet no worries. Thx for cherry picking the commit, that will solve some issues.

nl5887 commented Jul 28, 2016

@dadoonet no worries. Thx for cherry picking the commit, that will solve some issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment