Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of spaces for jvm.options on Windows #19951

Merged
merged 1 commit into from Aug 11, 2016

Conversation

Projects
None yet
2 participants
@jasontedor
Copy link
Member

commented Aug 11, 2016

This commit fixes the handling of spaces in the path to the jvm.options
file on Windows. The issue is that the extraneous set of quotes were
included as part of the value of ES_JVM_OPTIONS thus confusing further
downstream commands.

Closes #19941

Fix handling of spaces for jvm.options on Windows
This commit fixes the handling of spaces in the path to the jvm.options
file on Windows. The issue is that the extraneous set of quotes were
included as part of the value of ES_JVM_OPTIONS thus confusing further
downstream commands.
@dakrone

This comment has been minimized.

Copy link
Member

commented Aug 11, 2016

LGTM, wish we had packaging tests for windows :(

@jasontedor

This comment has been minimized.

Copy link
Member Author

commented Aug 11, 2016

LGTM, wish we had packaging tests for windows :(

Yes. :(

@jasontedor jasontedor merged commit d7dbb2b into elastic:master Aug 11, 2016

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci Build finished.
Details

@jasontedor jasontedor deleted the jasontedor:es-home-space-jvm-options branch Aug 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.