Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update and delete by query requests to implement IndicesRequest.Replaceable #19961

Merged
merged 2 commits into from Aug 11, 2016

Conversation

Projects
None yet
2 participants
@javanna
Copy link
Member

commented Aug 11, 2016

Delete by query is a shortcut to search + delete. Given that the request supports wildcards and allows to set its indices, it should implement IndicesRequest.Repleaceable.

Update by query is a shortcut to search + index. Given that the request supports wildcards and allows to set its indices, it should implement IndicesRequest.Repleaceable. implementing CompositeIndicesRequest makes little sense as the indices that the request works against depend entirely on the inner search request.

javanna added some commits Aug 11, 2016

DeleteByQueryRequest to implement IndicesRequest.Replaceable
Delete by query is a shortcut to search + delete. DeleteByQueryRequest gets serialized on the transport layer only when the transport client is used. Given that the request supports wildcards and allows to set its indices, it should implement IndicesRequest.Repleaceable
UpdateByQueryRequest to implement IndicesRequest.Replaceable rather t…
…han CompositeIndicesRequest

Update by query is a shortcut to search + index. UpdateByQueryRequest gets serialized on the transport layer only when the transport client is used. Given that the request supports wildcards and allows to set its indices, it should implement IndicesRequest.Repleaceable. implementing CompositeIndicesRequest makes little sense as the indices that the request works against depend entirely on the inner search request.
@nik9000

This comment has been minimized.

Copy link
Contributor

commented Aug 11, 2016

LGTM

@javanna javanna merged commit a80a35e into elastic:master Aug 11, 2016

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.