New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IndexTemplateFilter #20072

Merged
merged 2 commits into from Aug 20, 2016

Conversation

Projects
None yet
2 participants
@rjernst
Member

rjernst commented Aug 19, 2016

How index templates match is currently controlled by the
IndexTemplateFilter interface. It is pluggable, to add additional
filter implementations to the default glob matcher.

This change removes the IndexTemplateFilter interface completely. This
is a very esoteric extension point, and not worth maintaining. Instead,
any improvements should be made to all of our glob matching.

Plugins: Remove IndexTemplateFilter
How index templates match is currently controlled by the
IndexTemplateFilter interface. It is pluggable, to add additional
filter implementations to the default glob matcher.

This change removes the IndexTemplateFilter interface completely. This
is a very esoteric extension point, and not worth maintaining. Instead,
any improvements should be made to all of our glob matching.
@jpountz

This comment has been minimized.

Show comment
Hide comment
@jpountz

jpountz Aug 19, 2016

Contributor

Agreed. LGTM.

Contributor

jpountz commented Aug 19, 2016

Agreed. LGTM.

@rjernst rjernst merged commit 6ed83ce into elastic:master Aug 20, 2016

1 of 2 checks passed

elasticsearch-ci Build started sha1 is merged.
Details
CLA Commit author is a member of Elasticsearch
Details

@rjernst rjernst deleted the rjernst:remove_index_template_filter branch Aug 20, 2016

@clintongormley clintongormley changed the title from Plugins: Remove IndexTemplateFilter to Remove IndexTemplateFilter Aug 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment