New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve startup exception #20083

Merged
merged 2 commits into from Aug 19, 2016

Conversation

Projects
None yet
3 participants
@jasontedor
Member

jasontedor commented Aug 19, 2016

This pull request improves two items for StartupError:

  • rename StartupError to StartupException because this exception
    inherits from Exception not Error in the Throwable hierarchy
  • add print stack trace override to StartupException because sometimes
    the additional override is used to render a Throwable

jasontedor added some commits Aug 19, 2016

Rename StartupError to StartupException
This commit renames StartupError to StartupException. This rename is due
to the fact that this class inherits from Exception not Error in the
Throwable class hierarchy.
Add print stack trace override to StartupException
StartupException overrides Throwable#printStackTrace(PrintStream) but
not Throwable#printStackTrace(PrintWriter). The former override is used
when the JVM terminates with an exception, but the latter override can
be used in some logging frameworks when rendering an exception (e.g.,
log4j). This commit adds an override for the latter, with the behavior
for the two overrides being the same.
@nik9000

This comment has been minimized.

Show comment
Hide comment
@nik9000

nik9000 Aug 19, 2016

Contributor

LGTM

Contributor

nik9000 commented Aug 19, 2016

LGTM

@jasontedor jasontedor merged commit 6cda128 into elastic:master Aug 19, 2016

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci Build finished.
Details

@jasontedor jasontedor deleted the jasontedor:improve-startup-exception branch Aug 19, 2016

@jasontedor

This comment has been minimized.

Show comment
Hide comment
@jasontedor
Member

jasontedor commented Aug 19, 2016

Thanks @nik9000.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment