[SPEC] Change type of wait_for_active_shards from number to string

[gmarz]

Fixed all (most) instances where wait_for_active_shards was incorrectly typed as a string instead of number.

[abeyad]

@gmarz the original was correct, it is a "string" type because you can pass in to the query param all, default, or a string representation of an integer ("1", "2", etc) that will get parsed as a number. This type is a "string" to allow for all and default to be specified.

[clintongormley]

It looks like only rest-api-spec/src/main/resources/rest-api-spec/api/cluster.health.json needs to be changed to string

[abeyad]

@clintongormley actually that wait_for_active_shards in the cluster health APIs is different and is used only as an integer. So right now cluster.health.json is correct. But I do think we should consider changing it for consistency sake and also allow all and default (though in this case, default should be set to 0 instead of 1).

[gmarz]

But I do think we should consider changing it for consistency sake and also allow all and default

+1, definitely agree,

[gmarz]

@abeyad I've revised this PR and changed the type for cluster.health.json only.

[clintongormley]

LGTM

[abeyad]

I opened #20216 to discuss a proposal for the cluster health API