Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix match_phrase_prefix query with single term on _all field #20471

Merged
merged 2 commits into from Oct 10, 2016

Conversation

Projects
None yet
3 participants
@jimczi
Copy link
Member

commented Sep 14, 2016

This change fixes the match_phrase_prefix query when a single term is queried on the _all field.
It builds a prefix query instead of an AllTermQuery which would not match any prefix.

Fixes #20470

jimczi added some commits Sep 14, 2016

Fix match_phrase_prefix query with single term on _all field
This change fixes the match_phrase_prefix query when a single term is queried on the _all field.
It builds a prefix query instead of an AllTermQuery which would not match any prefix.

Fixes #20470
@clintongormley

This comment has been minimized.

Copy link
Member

commented Sep 14, 2016

thanks for fixing @jimferenczi - should we fix in 2.4 as well?

@jimczi jimczi added the v2.4.1 label Sep 14, 2016

@jimczi

This comment has been minimized.

Copy link
Member Author

commented Sep 14, 2016

@clintongormley sure, it's a one liner.

@jimczi jimczi added the review label Sep 16, 2016

@clintongormley clintongormley added v2.4.2 and removed v2.4.1 labels Sep 23, 2016

@jpountz
Copy link
Contributor

left a comment

LGTM

@jimczi jimczi merged commit 767a7e2 into elastic:master Oct 10, 2016

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci Build finished.
Details

jimczi added a commit that referenced this pull request Oct 10, 2016

Fix match_phrase_prefix query with single term on _all field (#20471)
* Fix match_phrase_prefix query with single term on _all field

This change fixes the match_phrase_prefix query when a single term is queried on the _all field.
It builds a prefix query instead of an AllTermQuery which would not match any prefix.

Fixes #20470

* Add missing change

jimczi added a commit that referenced this pull request Oct 10, 2016

Fix match_phrase_prefix query with single term on _all field (#20471)
* Fix match_phrase_prefix query with single term on _all field

This change fixes the match_phrase_prefix query when a single term is queried on the _all field.
It builds a prefix query instead of an AllTermQuery which would not match any prefix.

Fixes #20470

* Add missing change

jimczi added a commit that referenced this pull request Oct 10, 2016

Fix match_phrase_prefix query with single term on _all field (#20471)
* Fix match_phrase_prefix query with single term on _all field

This change fixes the match_phrase_prefix query when a single term is queried on the _all field.
It builds a prefix query instead of an AllTermQuery which would not match any prefix.

Fixes #20470

@jimczi jimczi deleted the jimczi:match_phrase_prefix_all branch Oct 10, 2016

@clintongormley clintongormley removed the v5.1.1 label Dec 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.