Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serial collector bootstrap check #20558

Merged
merged 1 commit into from Sep 20, 2016

Conversation

Projects
None yet
4 participants
@jasontedor
Copy link
Member

commented Sep 19, 2016

The serial collector is not suitable for running with a server
application like Elasticsearch and can decimate performance and lead to
cluster instability. This commit adds a bootstrap check to prevent usage
of the serial collector when Elasticsearch is running in production
mode.

Add serial collector bootstrap check
The serial collector is not suitable for running with a server
application like Elasticsearch and can decimate performance and lead to
cluster instability. This commit adds a bootstrap check to prevent usage
of the serial collector when Elasticsearch is running in production
mode.
@jasontedor

This comment has been minimized.

Copy link
Member Author

commented Sep 19, 2016

retest this please

@abeyad

abeyad approved these changes Sep 19, 2016

Copy link
Contributor

left a comment

LGTM

@jasontedor

This comment has been minimized.

Copy link
Member Author

commented Sep 19, 2016

retest this please


@Override
public boolean check() {
return getUseSerialGC().equals("true");

This comment has been minimized.

Copy link
@nik9000

nik9000 Sep 19, 2016

Contributor

Should this fail if the jvm returns a funny string like "rodent"? Should it log anything in that case? Should JvmInfo?

This comment has been minimized.

Copy link
@jasontedor

jasontedor Sep 19, 2016

Author Member

I don't think the bootstrap check should fail if it returns a funny string, I do think we can consider such things like logging in JvmInfo though; I'll take a look at that.

@jasontedor jasontedor merged commit 05b4e0c into elastic:master Sep 20, 2016

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci Build finished.
Details

jasontedor added a commit that referenced this pull request Sep 20, 2016

Add serial collector bootstrap check
The serial collector is not suitable for running with a server
application like Elasticsearch and can decimate performance and lead to
cluster instability. This commit adds a bootstrap check to prevent usage
of the serial collector when Elasticsearch is running in production
mode.

Relates #20558

jasontedor added a commit that referenced this pull request Sep 20, 2016

Add serial collector bootstrap check
The serial collector is not suitable for running with a server
application like Elasticsearch and can decimate performance and lead to
cluster instability. This commit adds a bootstrap check to prevent usage
of the serial collector when Elasticsearch is running in production
mode.

Relates #20558

@jasontedor jasontedor deleted the jasontedor:use-serial-gc-check branch Sep 20, 2016

@jasontedor

This comment has been minimized.

Copy link
Member Author

commented Sep 20, 2016

Thanks @abeyad and @nik9000.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.