Deprecating request parameters of _analyze API in 5.x #20686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add deprecation log Add deprecation description in the document Add deprecation test in rest-api-test and unit test Closes elastic#20246
johtani
added
>enhancement
review
:Search/Analysis
s1monw
approved these changes
Sep 29, 2016
nik9000
approved these changes
Sep 29, 2016
|
Thanks folks. Docs test is really cool! It is easy to find breaking changes in the docs. |
karmi
added a commit
that referenced
this pull request
Oct 15, 2016
…dices Analyze" tests As part of b6537d7, a check for the `Warnings` headers has been added. Since the feature might be temporarily or permanently not supported by all clients (as is the case with eg. the `headers` feature), we should allow them to skip the tests. Related: #20246, #20686 CC @johtani
karmi
added a commit
that referenced
this pull request
Oct 18, 2016
…dices Analyze" tests As part of b6537d7, a check for the `Warnings` headers has been added. Since the feature might be temporarily or permanently not supported by all clients (as is the case with eg. the `headers` feature), we should allow them to skip the tests. Related: #20246, #20686 Closes #20953
karmi
added a commit
that referenced
this pull request
Oct 18, 2016
…dices Analyze" tests As part of b6537d7, a check for the `Warnings` headers has been added. Since the feature might be temporarily or permanently not supported by all clients (as is the case with eg. the `headers` feature), we should allow them to skip the tests. Related: #20246, #20686 Closes #20953
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate request parameters of _analyze API in 5.x
Add deprecation log
Add deprecation description in the document
Add deprecation test in rest-api-test and unit test
Related #20246