Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for storing custom metadata in tribe node #20791

Closed

Conversation

Projects
None yet
3 participants
@areek
Copy link
Contributor

commented Oct 6, 2016

Currently, when any underlying cluster has custom metadata
(via plugin), tribe node does not store custom meta data in its
cluster state. This is because the tribe node has no idea how to
select the appropriate custom metadata from one or many custom
metadata (corresponding to the number of underlying clusters).

This change adds a hook to plugins to support reducing custom metadata
on the tribe node, so that tribe node can choose the most appropriate
custom metadata to store and notify on locally.

Relates to #20544

Add support for storing custom metadata in tribe node
Currently, when any underlying cluster has custom metadata
(via plugin), tribe node does not store custom meta data in its
cluster state. This is because the tribe node has no idea how to
select the appropriate custom metadata from one or many custom
metadata (corrosponding to the number of underlying clusters).

This change adds a hook to plugins to support reducing custom metadata
on the tribe node, so that tribe node can choose the most appropriate
custom metadata to store and notify on locally.

@areek areek force-pushed the areek:enhancment/plugin_tribe_custom_md_reducer branch to 447b797 Oct 7, 2016

@bleskes

This comment has been minimized.

Copy link
Member

commented Oct 12, 2016

I think we should coordinate with #20888 . I'll reach out to discuss.

@areek

This comment has been minimized.

Copy link
Contributor Author

commented Nov 14, 2016

closed in favour of #21552

@areek areek closed this Nov 14, 2016

areek added a commit to areek/elasticsearch that referenced this pull request Nov 17, 2016

Add support for merging custom meta data in tribe node
Currently, when any underlying cluster has custom metadata
(via plugin), tribe node does not store custom meta data in its
cluster state. This is because the tribe node has no idea how to
select the appropriate custom metadata from one or many custom
metadata (corresponding to the number of underlying clusters).

This change adds an interface that custom metadata implementations
can extend to add support for merging mulitple custom metadata of
the same type for storing in the tribe state.

Relates to elastic#20544
Supersedes elastic#20791

areek added a commit that referenced this pull request Nov 21, 2016

Add support for merging custom meta data in tribe node (#21552)
* Add support for merging custom meta data in tribe node

Currently, when any underlying cluster has custom metadata
(via plugin), tribe node does not store custom meta data in its
cluster state. This is because the tribe node has no idea how to
select the appropriate custom metadata from one or many custom
metadata (corresponding to the number of underlying clusters).

This change adds an interface that custom metadata implementations
can extend to add support for merging mulitple custom metadata of
the same type for storing in the tribe state.

Relates to #20544
Supersedes #20791

* Simplify updating tribe state

* Add tests for merging multiple custom metadata types in tribe node

* cleanup merging custom md logic in tribe service
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.