Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write -1 on unbounded queue in cat thread pool #21342

Merged
merged 1 commit into from Nov 4, 2016

Conversation

Projects
None yet
4 participants
@jasontedor
Copy link
Member

commented Nov 4, 2016

Today when writing an unbounded queue_size in the cat thread pool API,
we write null. This commit modifies this so that the output is -1 so
that the output is always present, and always a numeric value.

Closes #21187

Write -1 on unbounded queue in cat thread pool
Today when writing an unbounded queue_size in the cat thread pool API,
we write null. This commit modifies this so that the output is -1 so
that the output is always present, and always a numeric value.
@nik9000

nik9000 approved these changes Nov 4, 2016

@javanna

javanna approved these changes Nov 4, 2016

Copy link
Member

left a comment

LGTM, a bit on the fence on whether this should be considered a bug or an enhancement, and which branches it should go to. But I guess it is small enough to go to 5.x even if breaking and not considered a bug.

@jasontedor

This comment has been minimized.

Copy link
Member Author

commented Nov 4, 2016

LGTM, a bit on the fence on whether this should be considered a bug or an enhancement, and which branches it should go to. But I guess it is small enough to go to 5.x even if breaking and not considered a bug.

Yeah, I discussed it with @clintongormley via another channel and we decided it's an enhancement and very minor from a breaking perspective that we should include it in 5.1.0 but not 5.0.1.

@javanna

This comment has been minimized.

Copy link
Member

commented Nov 4, 2016

++ thanks Jason

@jasontedor jasontedor merged commit 848eef4 into elastic:5.x Nov 4, 2016

1 check passed

CLA Commit author is a member of Elasticsearch
Details

jasontedor added a commit that referenced this pull request Nov 4, 2016

Write -1 on unbounded queue in cat thread pool
Today when writing an unbounded queue_size in the cat thread pool API,
we write null. This commit modifies this so that the output is -1 so
that the output is always present, and always a numeric value.

Relates #21342

@jasontedor jasontedor deleted the jasontedor:queue_size-cat-thread-pool branch Nov 4, 2016

@jasontedor

This comment has been minimized.

Copy link
Member Author

commented Nov 4, 2016

Thank you @nik9000 and @javanna.

jasontedor added a commit that referenced this pull request Nov 9, 2016

@jasontedor jasontedor removed the v5.1.1 label Nov 9, 2016

jasontedor added a commit that referenced this pull request Nov 9, 2016

Add migration docs for cat API
This commit adds migration docs for the cat API, including a note
regarding the change in response in the cat thread pool API for
unbounded queue sizes.

Relates #21342

jasontedor added a commit that referenced this pull request Nov 9, 2016

Remove 5.x references from cat API migration doc
This commit removes some references to 5.x that were picked up when the
migration docs for the cat API were migrated from 5.x to master.

Relates #21342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.