Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RankEval: Add optional parameter to ignore unlabeled documents in Precision metric #21408

Conversation

Projects
None yet
3 participants
@cbuescher
Copy link
Member

commented Nov 8, 2016

Our current default behaviour to ignore unrated documents when calculating the precision seems a bit counter intuitive. Instead we should treat those documents
as "irrelevant" by default and provide an optional parameter to ignore those documents if that is the behaviour the user wants.

Closes #21304

RankEval: Add optional parameter to ignore unlabeled documents in Pre…
…cision metric

Our current default behaviour to ignore unrated documents when calculating the
precision seems a bit counter intuitive. Instead we should treat those documents
as "irrelevant" by default and provide an optional parameter to ignore those
documents if that is the behaviour the user wants.
@cbuescher

This comment has been minimized.

Copy link
Member Author

commented Nov 8, 2016

@MaineC after thinking a bit about it, I think this is a more intuitive default behaviour for precision.

@MaineC

This comment has been minimized.

Copy link
Contributor

commented Nov 9, 2016

I like the change. LGTM

@cbuescher cbuescher merged commit 4e5c868 into elastic:feature/rank-eval Nov 9, 2016

1 check passed

CLA Commit author is a member of Elasticsearch
Details

@cbuescher cbuescher deleted the cbuescher:rankEval-addIgnoreUnlabeled-Precision branch Nov 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.