New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove groovy scripting language #21607

Merged
merged 3 commits into from Nov 23, 2016

Conversation

Projects
None yet
4 participants
@rjernst
Member

rjernst commented Nov 17, 2016

Groovy was deprecated in 5.0. This change removes it, along with the
legacy default language infrastructure in scripting.

Scripting: Remove groovy scripting language
Groovy was deprecated in 5.0. This change removes it, along with the
legacy default language infrastructure in scripting.
@jpountz

It looks good to me. As a follow-up, maybe we should add a note to the 5.x percolator docs to tell users that percolator queries should use painless or expressions, or the index storing those queries won't load in 6.0.

@@ -45,7 +45,7 @@
},
"lang": {
"type": "string",
"description": "The script language (default: groovy)"
"description": "The script language (default: painless)"

This comment has been minimized.

@jpountz

jpountz Nov 17, 2016

Contributor

maybe this part should be backported to 5.x

@jpountz

jpountz Nov 17, 2016

Contributor

maybe this part should be backported to 5.x

This comment has been minimized.

@rjernst

rjernst Nov 23, 2016

Member

I pushed 60f70bc to 5.x

@rjernst

rjernst Nov 23, 2016

Member

I pushed 60f70bc to 5.x

@clintongormley clintongormley changed the title from Scripting: Remove groovy scripting language to Remove groovy scripting language Nov 19, 2016

@jdconrad

This comment has been minimized.

Show comment
Hide comment
@jdconrad

jdconrad Nov 21, 2016

Contributor

@rjernst This can not be checked in fast enough, are you busy or something :)?

Contributor

jdconrad commented Nov 21, 2016

@rjernst This can not be checked in fast enough, are you busy or something :)?

@rjernst rjernst merged commit 6940b2b into elastic:master Nov 23, 2016

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci Build finished.
Details

@rjernst rjernst deleted the rjernst:groovy_goes_boom branch Nov 23, 2016

javanna added a commit to javanna/elasticsearch that referenced this pull request Feb 8, 2017

Remove getDefaultScriptingLanguage from QueryParseContext
The method is not needed anymore, was needed only when we supported setting a legacy default lang, which was removed with #21607

Relates to #21607

javanna added a commit that referenced this pull request Feb 9, 2017

Remove getDefaultScriptingLanguage from QueryParseContext (#23043)
The method is not needed anymore, was needed only when we supported setting a legacy default lang, which was removed with #21607

Relates to #21607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment