Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose `ip` fields as strings in scripts. #21997

Merged
merged 1 commit into from Dec 7, 2016

Conversation

Projects
None yet
2 participants
@jpountz
Copy link
Contributor

commented Dec 6, 2016

Currently we expose the internal representation that we use for ip addresses,
which are the ipv6 bytes. However, this is not really usable, exposes internal
implementation details and also does not work fine with other APIs that expect
that the values can be toString'd.

Closes #21977

Expose `ip` fields as strings in scripts.
Currently we expose the internal representation that we use for ip addresses,
which are the ipv6 bytes. However, this is not really usable, exposes internal
implementation details and also does not work fine with other APIs that expect
that the values can be `toString`'d.

Closes #21977
@rjernst

This comment has been minimized.

Copy link
Member

commented Dec 6, 2016

LGTM

@jpountz jpountz merged commit 33b8d7a into elastic:master Dec 7, 2016

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci Build finished.
Details

jpountz added a commit that referenced this pull request Dec 7, 2016

Expose `ip` fields as strings in scripts. (#21997)
Currently we expose the internal representation that we use for ip addresses,
which are the ipv6 bytes. However, this is not really usable, exposes internal
implementation details and also does not work fine with other APIs that expect
that the values can be `toString`'d.

Closes #21977

@Bargs Bargs referenced this pull request Dec 12, 2016

Merged

add top_hit metric #7302

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.