Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an exception on unrecognized "match_mapping_type" #22090

Merged
merged 1 commit into from Dec 12, 2016

Conversation

Projects
None yet
2 participants
@dakrone
Copy link
Member

commented Dec 9, 2016

When using dynamic templates, ES will now throw an exception if a
match_mapping_type is used that doesn't correspond to an actual type.

Relates to #17285

I was reminded of this from a recent post on discuss.elastic.co where a user had used "text" instead of "string".

@jpountz
Copy link
Contributor

left a comment

LGTM

@jpountz

This comment has been minimized.

Copy link
Contributor

commented Dec 10, 2016

Maybe add a line about it in the migration guide?

@dakrone

This comment has been minimized.

Copy link
Member Author

commented Dec 12, 2016

@jpountz good idea, I will do that when merging this, thanks!

Throw an exception on unrecognized "match_mapping_type"
When using dynamic templates, ES will now throw an exception if a
`match_mapping_type` is used that doesn't correspond to an actual type.

Relates to #17285

@dakrone dakrone force-pushed the dakrone:throw-on-bad-mmt branch to a4e8b5d Dec 12, 2016

@dakrone dakrone merged commit a4e8b5d into elastic:master Dec 12, 2016

2 checks passed

CLA Commit author has signed the CLA
Details
elasticsearch-ci Build finished.
Details

thomasneirynck added a commit to thomasneirynck/makelogs that referenced this pull request Dec 15, 2016

use string mapping type
This is due to the following change in ES, which now throws an exception when using the 'text' type. elastic/elasticsearch#22090

Bargs added a commit to Bargs/makelogs that referenced this pull request Dec 15, 2016

Fix mapper_parsing_exception
ES is now [throwing exceptions][1] when `match_mapping_type` contains
an invalid value. `text` is an invalid value, we must use `string` for
this [particular property]. Makelogs would get this error and stop
execution, failing to index any documents or create a template.

[1]: elastic/elasticsearch#22090
[2]: elastic/elasticsearch#16945

@Bargs Bargs referenced this pull request Dec 15, 2016

Merged

Fix mapper_parsing_exception #29

@dakrone dakrone deleted the dakrone:throw-on-bad-mmt branch Jan 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.