Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow plugins to install bootstrap checks #22110

Merged
merged 3 commits into from Dec 12, 2016

Conversation

Projects
None yet
3 participants
@s1monw
Copy link
Contributor

s1monw commented Dec 12, 2016

Plugins also have the need to provide better OOTB experience by configuring
defaults unless the plugin is used in production mode. This change exposes
the bootstrap check infrastructure as part of the plugin API to allow plugins
to specify / install their own bootstrap checks if necessary.

Allow plugins to install bootstrap checks
Plugins also have the need to provide better OOTB experience by configuring
defaults unless the plugin is used in _production_ mode. This change exposes
the bootstrap check infrastructure as part of the plugin API to allow pluigns
to specify / install their own bootstrap checks if necessary.
@dadoonet

This comment has been minimized.

Copy link
Member

dadoonet commented Dec 12, 2016

Lovely.

Do you think it is worth adding some doc about getBootstrapChecks() in our developer guide?

@s1monw

This comment has been minimized.

Copy link
Contributor Author

s1monw commented Dec 12, 2016

Do you think it is worth adding some doc about getBootstrapChecks() in our developer guide?

I am not sure, there are javadocs for this on the Plugin.java class. I wonder if we should really duplicate efforts? I think we can add a reference to this that plugins can also add those checks?

@dadoonet

This comment has been minimized.

Copy link
Member

dadoonet commented Dec 12, 2016

I think we can add a reference to this that plugins can also add those checks?

That would be nice indeed so folks who are reading docs won't be surprised if a plugin barks at startup.

@dadoonet
Copy link
Member

dadoonet left a comment

Very nice.

As you said, can you add some doc in bootstrap checks?

@s1monw

This comment has been minimized.

Copy link
Contributor Author

s1monw commented Dec 12, 2016

@elasticmachine test this please

@jasontedor
Copy link
Member

jasontedor left a comment

I left one suggestion, but it LGTM either way.

/**
* Encapsulates a bootstrap check.
*/
public interface Check {

This comment has been minimized.

Copy link
@jasontedor

jasontedor Dec 12, 2016

Member

I wonder if this class should be renamed to BootstrapCheck and the currently-existing BootstrapCheck should be renamed to BootstrapChecks (or something like that, basically looking to give Check a more indicative name now that it is not an nested class in BootstrapCheck)?

@s1monw

This comment has been minimized.

Copy link
Contributor Author

s1monw commented Dec 12, 2016

@elasticmachine test this please

@s1monw s1monw merged commit b667ff4 into elastic:master Dec 12, 2016

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci Build finished.
Details

@s1monw s1monw deleted the s1monw:enable_plugin_bootstrap_checks branch Dec 12, 2016

s1monw added a commit that referenced this pull request Dec 12, 2016

Allow plugins to install bootstrap checks (#22110)
Plugins also have the need to provide better OOTB experience by configuring
defaults unless the plugin is used in _production_ mode. This change exposes
the bootstrap check infrastructure as part of the plugin API to allow plugins
to specify / install their own bootstrap checks if necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.