Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use null charset in RequestLogger #22197

Merged
merged 1 commit into from Dec 15, 2016
Merged

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Dec 15, 2016

If the response comes back with a content type with a null
charset we were blindly using it, causing NullPointerExceptions.

Closes #22190

If the response comes back with a content type with a `null`
charset we were blindly using it, causing `NullPointerException`s.

Closes elastic#22190
@nik9000
Copy link
Member Author

nik9000 commented Dec 15, 2016

@javanna, can you have a look at this one?

Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@nik9000 nik9000 merged commit 2aa8982 into elastic:master Dec 15, 2016
@nik9000
Copy link
Member Author

nik9000 commented Dec 15, 2016

Thanks for reviewing @javanna !

master: 2aa8982
5.x: 12c0c5a
5.1: f78a1d1

nik9000 added a commit that referenced this pull request Dec 15, 2016
If the response comes back with a content type with a `null`
charset we were blindly using it, causing `NullPointerException`s.

Closes #22190
nik9000 added a commit that referenced this pull request Dec 15, 2016
If the response comes back with a content type with a `null`
charset we were blindly using it, causing `NullPointerException`s.

Closes #22190
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants