Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reversed ShingleFilter constructor arguments #2226

Closed

Conversation

@kennknowles
Copy link
Contributor

kennknowles commented Aug 31, 2012

The ShingleTokenFilterFactory in ElasticSearch reverses the minShingleSize and maxShingleSize arguments to the underlying Lucene ShingleFilter

For reference, here is a script that reproduces the issue clearly (tested against 0.19.9): https://gist.github.com/3558149

@kimchy

This comment has been minimized.

Copy link
Member

kimchy commented Aug 31, 2012

Applied to both 0.19 and master, cheers!

@kimchy kimchy closed this Aug 31, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.