Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated percolate and mpercolate apis #22331

Merged
merged 1 commit into from Jan 10, 2017

Conversation

Projects
None yet
3 participants
@martijnvg
Copy link
Member

commented Dec 22, 2016

No description provided.

@martijnvg martijnvg force-pushed the martijnvg:remove_percolator_apis branch Dec 22, 2016

@dadoonet
Copy link
Member

left a comment

Nice stats. I left a comment about the tests you migrated / added.

@@ -605,4 +603,82 @@ public void testPercolateQueryWithNestedDocuments() throws Exception {
assertHitCount(response, 0);
}

public void testPercolatorQueryViaMultiSearch() throws Exception {

This comment has been minimized.

Copy link
@dadoonet

dadoonet Dec 22, 2016

Member

Does this should also go in 5.x branches actually?

This comment has been minimized.

Copy link
@martijnvg

martijnvg Dec 22, 2016

Author Member

Good point. I'll move these tests separately to the 5.x branch.

@@ -1,56 +0,0 @@
---
"Basic multi-percolate":

This comment has been minimized.

Copy link
@nik9000

nik9000 Dec 22, 2016

Contributor

Does msearch need a test for this?

This comment has been minimized.

Copy link
@martijnvg

martijnvg Dec 27, 2016

Author Member

Agreed, I added a basic test for both the search and msearch apis using a percolate query.

---
"Basic percolation tests":

- do:

This comment has been minimized.

Copy link
@nik9000

nik9000 Dec 22, 2016

Contributor

What about these? I didn't see them in 5.x but maybe I didn't look super closely.

This comment has been minimized.

Copy link
@martijnvg

martijnvg Dec 27, 2016

Author Member

Agreed, I added a basic test for both the search and msearch apis using a percolate query.

@martijnvg martijnvg force-pushed the martijnvg:remove_percolator_apis branch Dec 27, 2016

@martijnvg

This comment has been minimized.

Copy link
Member Author

commented Dec 27, 2016

Thanks for checking this out @nik9000 @dadoonet! I've updated the PR.

@martijnvg martijnvg force-pushed the martijnvg:remove_percolator_apis branch Jan 9, 2017

@martijnvg martijnvg force-pushed the martijnvg:remove_percolator_apis branch to cb2333d Jan 10, 2017

@martijnvg martijnvg merged commit cb2333d into elastic:master Jan 10, 2017

1 of 2 checks passed

elasticsearch-ci Build started sha1 is merged.
Details
CLA Commit author is a member of Elasticsearch
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.