Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scaled_float numeric type in aggregations #22351

Merged
merged 3 commits into from Dec 27, 2016

Conversation

Projects
None yet
2 participants
@jimczi
Copy link
Member

jimczi commented Dec 26, 2016

scaled_float should be used as FLOAT in aggregations but currently they are used as LONG.
This change fixes this issue and adds a simple it test for it.

Fixes #22350

jimczi added some commits Dec 26, 2016

Fix scaled_float numeric type in aggregations
`scaled_float` should be used as FLOAT in aggregations but currently they are used as LONG.
This change fixes this issue and adds a simple it test for it.
@jpountz
Copy link
Contributor

jpountz left a comment

LGTM

/**
* {@link ScaledFloatLeafFieldData#getDoubleValues()} transforms the raw long values in `scaled` floats.
*/
return NumericType.FLOAT;

This comment has been minimized.

Copy link
@jpountz

jpountz Dec 26, 2016

Contributor

I don't think that will change anything in practice, but I think the correct value would be DOUBLE?

@jimczi jimczi merged commit e7444f7 into elastic:master Dec 27, 2016

1 check was pending

elasticsearch-ci Build started sha1 is merged.
Details

@jimczi jimczi deleted the jimczi:scaled_float_cast branch Dec 27, 2016

jimczi added a commit that referenced this pull request Dec 27, 2016

Fix scaled_float numeric type in aggregations (#22351)
`scaled_float` should be used as DOUBLE in aggregations but currently they are used as LONG.
This change fixes this issue and adds a simple it test for it.

Fixes #22350
@jimczi

This comment has been minimized.

Copy link
Member Author

jimczi commented Dec 27, 2016

Thanks @jpountz
This is now pushed to master and 5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.