Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute low level handshake in #openConnection #22440

Merged
merged 3 commits into from Jan 5, 2017

Conversation

Projects
None yet
2 participants
@s1monw
Copy link
Contributor

commented Jan 4, 2017

Today we execute the low level handshake on the TCP layer in #connectToNode.
If #openConnection is used directly, which is truly expert, no handshake is executed
which allows connecting to nodes that are not necessarily compatible. This change
moves the handshake to #openConnection to prevent bypassing this logic.

Execute low level handshake in #openConnection
Today we execute the low level handshake on the TCP layer in #connectToNode.
If #openConnection is used directly, which is truly expert, no handshake is executed
which allows connecting to nodes that are not necessarily compatible. This change
moves the handshake to #openConnection to prevent bypassing this logic.
@jasontedor
Copy link
Member

left a comment

LGTM.

@s1monw s1monw merged commit a5daa5d into elastic:master Jan 5, 2017

1 of 2 checks passed

elasticsearch-ci Build started sha1 is merged.
Details
CLA Commit author is a member of Elasticsearch
Details

@s1monw s1monw deleted the s1monw:handshake_on_connection_open branch Jan 5, 2017

s1monw added a commit that referenced this pull request Jan 5, 2017

Execute low level handshake in #openConnection (#22440)
Today we execute the low level handshake on the TCP layer in #connectToNode.
If #openConnection is used directly, which is truly expert, no handshake is executed
which allows connecting to nodes that are not necessarily compatible. This change
moves the handshake to #openConnection to prevent bypassing this logic.

s1monw added a commit that referenced this pull request Jan 5, 2017

Execute low level handshake in #openConnection (#22440)
Today we execute the low level handshake on the TCP layer in #connectToNode.
If #openConnection is used directly, which is truly expert, no handshake is executed
which allows connecting to nodes that are not necessarily compatible. This change
moves the handshake to #openConnection to prevent bypassing this logic.

s1monw added a commit that referenced this pull request Jan 5, 2017

Use provided node version if node doesn't implement low level handshake
In 5.2 a TCP level handshake was introduced to negotiate the communication
/ serialization version between nodes. Yet, if we are talking to a pre 5.2 node
we don't get a version back from a handshake and therefore must rely on the
version provided by the caller.

Relates to #22440

s1monw added a commit that referenced this pull request Jan 5, 2017

Use provided node version if node doesn't implement low level handshake
In 5.2 a TCP level handshake was introduced to negotiate the communication
/ serialization version between nodes. Yet, if we are talking to a pre 5.2 node
we don't get a version back from a handshake and therefore must rely on the
version provided by the caller.

Relates to #22440
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.