Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure shrunk indices carry over version information from its source #22469

Merged
merged 1 commit into from Jan 6, 2017

Conversation

Projects
None yet
4 participants
@s1monw
Copy link
Contributor

commented Jan 6, 2017

Today when an index is shrunk the version information is not carried over
from the source to the target index. This can cause major issues like mapping
incompatibilities for instance if an index from a previous major version is shrunk.

This commit ensures that all version information from the soruce index is preserved
when a shrunk index is created.

Closes #22373

Ensure shrunk indices carry over version information from its source
Today when an index is shrunk the version information is not carried over
from the source to the target index. This can cause major issues like mapping
incompatibilities for instance if an index from a previous major version is shrunk.

This commit ensures that all version information from the soruce index is preserved
when a shrunk index is created.

Closes #22373
@gmoskovicz

This comment has been minimized.

Copy link
Contributor

commented Jan 6, 2017

Sweet, thanks @s1monw

@ywelsch

ywelsch approved these changes Jan 6, 2017

Copy link
Contributor

left a comment

LGTM

@s1monw s1monw merged commit 79093e1 into elastic:master Jan 6, 2017

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci Build finished.
Details

@s1monw s1monw deleted the s1monw:issues/22373 branch Jan 6, 2017

s1monw added a commit that referenced this pull request Jan 6, 2017

Ensure shrunk indices carry over version information from its source (#…
…22469)

Today when an index is shrunk the version information is not carried over
from the source to the target index. This can cause major issues like mapping
incompatibilities for instance if an index from a previous major version is shrunk.

This commit ensures that all version information from the soruce index is preserved
when a shrunk index is created.

Closes #22373

s1monw added a commit that referenced this pull request Jan 6, 2017

Ensure shrunk indices carry over version information from its source (#…
…22469)

Today when an index is shrunk the version information is not carried over
from the source to the target index. This can cause major issues like mapping
incompatibilities for instance if an index from a previous major version is shrunk.

This commit ensures that all version information from the soruce index is preserved
when a shrunk index is created.

Closes #22373

s1monw added a commit that referenced this pull request Feb 21, 2017

Ensure shrunk indices carry over version information from its source (#…
…22469)

Today when an index is shrunk the version information is not carried over
from the source to the target index. This can cause major issues like mapping
incompatibilities for instance if an index from a previous major version is shrunk.

This commit ensures that all version information from the soruce index is preserved
when a shrunk index is created.

Closes #22373

@s1monw s1monw added v5.2.2 and removed v5.2.0 labels Feb 21, 2017

@s1monw

This comment has been minimized.

Copy link
Contributor Author

commented Feb 21, 2017

this PR was not pushed to 5.2.0 and 5.2.1 it will be in 5.2.2 if we release this branch again. Sorry for the inconvenience. I simply missed the backport for some reason. Thanks @gmoskovicz for pointing this out to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.