Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix primary relocation for shadow replicas #22474

Merged

Conversation

Projects
None yet
3 participants
@ywelsch
Copy link
Contributor

commented Jan 6, 2017

Primary relocation for shadow replicas is broken as the recovery process accesses the engine on the source shard after it's been closed. This results in the source shard failing itself. This has not been detected by tests as, after failing source and target shard of the relocation, the master simply reassigns the primary to the node where it wanted to relocate to as every node has access to the shard files.

Test failure exhibiting behavior (might be an un-related issue though):

https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+periodic/1282/consoleFull

Relates to #20300

@s1monw

s1monw approved these changes Jan 6, 2017

Copy link
Contributor

left a comment

LGTM good catch

@ywelsch ywelsch merged commit 8741691 into elastic:master Jan 8, 2017

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci Build finished.
Details

ywelsch added a commit that referenced this pull request Jan 8, 2017

Fix primary relocation for shadow replicas (#22474)
The recovery process started during primary relocation of shadow replicas accesses the engine on the source shard after it's been closed, which results in the source shard failing itself.

ywelsch added a commit that referenced this pull request Jan 8, 2017

Fix primary relocation for shadow replicas (#22474)
The recovery process started during primary relocation of shadow replicas accesses the engine on the source shard after it's been closed, which results in the source shard failing itself.

ywelsch added a commit that referenced this pull request Jan 8, 2017

Fix primary relocation for shadow replicas (#22474)
The recovery process started during primary relocation of shadow replicas accesses the engine on the source shard after it's been closed, which results in the source shard failing itself.

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Jan 8, 2017

Merge branch 'master' into replica-sequence-number-recovery
* master:
  [TEST] Fixed the incorrect indentation for the `skip` clauses in the REST tests
  Fix primary relocation for shadow replicas (elastic#22474)

@clintongormley clintongormley removed the v5.3.0 label Jan 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.