Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use namedObject to parse AllocationCommands #22489

Merged
merged 1 commit into from Jan 9, 2017

Conversation

Projects
None yet
2 participants
@nik9000
Copy link
Contributor

commented Jan 8, 2017

This removes AllocationCommandRegistry entirely and replaces
it with XContentParser#namedObject, removing another class from
guice.

Use namedObject to parse AllocationCommands
This removes `AllocationCommandRegistry` entirely and replaces
it with `XContentParser#namedObject`, removing another class from
guice.
@nik9000

This comment has been minimized.

Copy link
Contributor Author

commented Jan 8, 2017

@javanna, could I trouble you to have a look at this? If someone else wants it, I'm not picky.

private static final List<NamedWriteableRegistry.Entry> namedWriteables = new ArrayList<>();

private final Map<String, Supplier<Transport>> transportFactories = new HashMap<>();

This comment has been minimized.

Copy link
@nik9000

nik9000 Jan 8, 2017

Author Contributor

I moved these below that static initializer block.

@nik9000 nik9000 added the :Internal label Jan 8, 2017

public ParseFieldMatcher getParseFieldMatcher() {
return parseFieldMatcher;
}
}

This comment has been minimized.

Copy link
@javanna

javanna Jan 9, 2017

Member

oh seems like you also removed some ParseFieldMatcher usages, nice :)

This comment has been minimized.

Copy link
@nik9000

nik9000 Jan 9, 2017

Author Contributor

I'm helping!

@javanna

javanna approved these changes Jan 9, 2017

Copy link
Member

left a comment

LGTM

@nik9000 nik9000 merged commit f75ef7a into elastic:master Jan 9, 2017

2 checks passed

CLA Commit author has signed the CLA
Details
elasticsearch-ci Build finished.
Details
@nik9000

This comment has been minimized.

Copy link
Contributor Author

commented Jan 9, 2017

Thanks for reviewing @javanna!

master: f75ef7a
5.x: a55f0b8

nik9000 added a commit that referenced this pull request Jan 9, 2017

Use namedObject to parse AllocationCommands (#22489)
This removes `AllocationCommandRegistry` entirely and replaces
it with `XContentParser#namedObject`, removing another class from
guice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.