Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace SearchExtRegistry with namedObject #22492

Merged
merged 1 commit into from Jan 9, 2017

Conversation

Projects
None yet
2 participants
@nik9000
Copy link
Contributor

commented Jan 8, 2017

This is the last thing in SearchRequestParsers. After this
is merged we should be able to drop it.

Breaks java plugins registering SearchExtParsers by making
the registration more standard.

Replace SearchExtRegistry with namedObject
This is the last thing in `SearchRequestParsers`. After this
is merged we should be able to drop it.
@nik9000

This comment has been minimized.

Copy link
Contributor Author

commented Jan 8, 2017

@javanna, yet more fun for you, if you want it.

@s1monw

s1monw approved these changes Jan 9, 2017

Copy link
Contributor

left a comment

LGTM

@s1monw

This comment has been minimized.

Copy link
Contributor

commented Jan 9, 2017

@elasticmachine test this please

@nik9000 nik9000 merged commit f4884e0 into elastic:master Jan 9, 2017

2 checks passed

CLA Commit author has signed the CLA
Details
elasticsearch-ci Build finished.
Details
@nik9000

This comment has been minimized.

Copy link
Contributor Author

commented Jan 9, 2017

Thanks for reviewing @s1monw!

master: f4884e0
5.x: 9c880f0

nik9000 added a commit that referenced this pull request Jan 9, 2017

Replace SearchExtRegistry with namedObject (#22492)
This is one of the last things in `SearchRequestParsers`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.