Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ParseFieldMatcher and ParseFieldMatcherSupplier #22581

Merged

Conversation

Projects
None yet
2 participants
@javanna
Copy link
Member

commented Jan 12, 2017

This PR removes all of the remaining usages of ParseFieldMatcher so that we can remove the class and ParseFieldMatcherSupplier.

Closes #19552

core/src/test/java/org/elasticsearch/search/aggregations/AggregatorFactoriesTests.java Outdated
}


public void testGetAggregatorFactories_returnsUnmodifiableList() {
public void testGetAggregatorFactories_returnsUnmodifiableList() {

This comment has been minimized.

Copy link
@nik9000

nik9000 Jan 12, 2017

Contributor

Lost the indent.

String chiSquare = "\"chi_square\":{\"include_negatives\": " + includeNegatives + ", \"background_is_superset\":"
+ backgroundIsSuperset + "}";
assertEquals(new ChiSquare(includeNegatives, backgroundIsSuperset),
parseFromString(heuristicParserMapper, searchContext, chiSquare));

This comment has been minimized.

Copy link
@nik9000

nik9000 Jan 12, 2017

Contributor

Much nicer!

@javanna javanna force-pushed the javanna:enhancement/remove_parse_field_matcher_last branch to eec7f30 Jan 12, 2017

@javanna javanna merged commit 8e8ac5f into elastic:master Jan 12, 2017

1 of 2 checks passed

elasticsearch-ci Build started sha1 is merged.
Details
CLA Commit author is a member of Elasticsearch
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.