Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass `forceExecution` flag to transport interceptor #22739

Merged
merged 3 commits into from Jan 23, 2017

Conversation

Projects
None yet
2 participants
@s1monw
Copy link
Contributor

s1monw commented Jan 23, 2017

To effectively allow a plugin to intercept a transport handler it needs
to know if the handler must be executed even if there is a rejection on the
thread pool in the case the wrapper forks a thread to execute the actual handler.

Pass `forceExecution` flag to transport interceptor
To effectivly allow a plugin to intercept a transport handler it needs
to know if the handler must be executed even if there is a rejection on the
thread pool in the case the wrapper forks a thread to execute the actual handler.
@ywelsch
Copy link
Contributor

ywelsch left a comment

LGTM

@@ -236,9 +235,10 @@ private CompositeTransportInterceptor(List<TransportInterceptor> transportInterc

@Override
public <T extends TransportRequest> TransportRequestHandler<T> interceptHandler(String action, String executor,
TransportRequestHandler<T> actualHandler) {
TransportRequestHandler<T> actualHandler,
boolean forceExecution) {

This comment has been minimized.

Copy link
@ywelsch

ywelsch Jan 23, 2017

Contributor

just a nit: maybe pass forceExecution before actualHandler so that the order is similar to the registerRequestHandler method

@s1monw s1monw merged commit 27b5c2a into elastic:master Jan 23, 2017

1 check was pending

elasticsearch-ci Build started sha1 is merged.
Details

@s1monw s1monw deleted the s1monw:pass_force_exec branch Jan 23, 2017

s1monw added a commit that referenced this pull request Jan 23, 2017

Pass `forceExecution` flag to transport interceptor (#22739)
To effectively allow a plugin to intercept a transport handler it needs
to know if the handler must be executed even if there is a rejection on the
thread pool in the case the wrapper forks a thread to execute the actual handler.

s1monw added a commit that referenced this pull request Jan 23, 2017

Pass `forceExecution` flag to transport interceptor (#22739)
To effectively allow a plugin to intercept a transport handler it needs
to know if the handler must be executed even if there is a rejection on the
thread pool in the case the wrapper forks a thread to execute the actual handler.

s1monw added a commit that referenced this pull request Jan 23, 2017

Pass `forceExecution` flag to transport interceptor (#22739)
To effectively allow a plugin to intercept a transport handler it needs
to know if the handler must be executed even if there is a rejection on the
thread pool in the case the wrapper forks a thread to execute the actual handler.

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Jan 23, 2017

Merge branch 'master' into replica-sequence-number-recovery
* master: (33 commits)
  Docs fix - Added missing link to new Adjacency-matrix agg
  Pass `forceExecution` flag to transport interceptor (elastic#22739)
  Version: Add missing releases from 2.x in Version.java (elastic#22594)
  CONSOLE-ify filter aggregation docs
  CONSOLE-ify date_range aggregation docs
  Add single static instance of SpecialPermission (elastic#22726)
  Simplify InternalEngine#innerIndex (elastic#22721)
  Upgrade to Lucene 6.4.0 (elastic#22724)
  Fix broken TaskInfo.toString()
  Add CheckedSupplier and CheckedRunnable to core (elastic#22725)
  Revert "Make build Gradle 2.14 / 3.x compatible (elastic#22669)"
  Fixes retrieval of the latest snapshot index blob (elastic#22700)
  CONSOLE-ify date histogram docs
  CONSOLE-ify min and max aggregation docs
  CONSOLE-ify global-aggregation.asciidoc
  Fix script score function that combines _score and weight (elastic#22713)
  Corrected a plural verb to a singular one. (elastic#22681)
  Fix duplicates from search.query (elastic#22701)
  Readd unconverted snippets mark for doc
  Deguice rest handlers (elastic#22575)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.