Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing mime4j library #22764

Merged
merged 2 commits into from Jan 25, 2017

Conversation

Projects
None yet
3 participants
@dadoonet
Copy link
Member

commented Jan 24, 2017

In some cases (apparently with outlook files), mime4j library is needed.
We removed it in the past which can cause elasticsearch to crash when you are using ingest-attachment (and probably mapper-attachments as well in 2.x series) with a file which requires this library.

Similar problem as the one reported at #22077.

Add missing mime4j library
In some cases (apparently with outlook files), mime4j library is needed.
We removed it in the past which can cause elasticsearch to crash when you are using ingest-attachment (and probably mapper-attachments as well in 2.x series) with a file which requires this library.

 Similar problem as the one reported at #22077.
@jasontedor
Copy link
Member

left a comment

Can you add a test document that fails without the dependency and passes with it?

@dadoonet

This comment has been minimized.

Copy link
Member Author

commented Jan 25, 2017

@clintongormley clintongormley added the >bug label Jan 25, 2017

@jasontedor
Copy link
Member

left a comment

LGTM.

@dadoonet dadoonet merged commit ee3d73d into elastic:master Jan 25, 2017

1 of 2 checks passed

elasticsearch-ci Build finished.
Details
CLA Commit author is a member of Elasticsearch
Details

dadoonet added a commit to dadoonet/elasticsearch that referenced this pull request Jan 26, 2017

Add missing mime4j library
In some cases (apparently with outlook files), mime4j library is needed.
We removed it in the past which can cause elasticsearch to crash when you are using ingest-attachment (and probably mapper-attachments as well in 2.x series) with a file which requires this library.

Backport of elastic#22764 in 5.x branch

dadoonet added a commit to dadoonet/elasticsearch that referenced this pull request Jan 26, 2017

Add missing mime4j library
Applying same changes as elastic#22764 but for mapper-attachments plugin (5.x branch)

dadoonet added a commit that referenced this pull request Feb 1, 2017

Add missing mime4j library
In some cases (apparently with outlook files), mime4j library is needed.
We removed it in the past which can cause elasticsearch to crash when you are using ingest-attachment (and probably mapper-attachments as well in 2.x series) with a file which requires this library.

Backport of #22764 in 5.2 branch

(cherry picked from commit cfef7c5)

dadoonet added a commit that referenced this pull request Feb 1, 2017

Add missing mime4j library
Applying same changes as #22764 but for mapper-attachments plugin (5.2 branch)

(cherry picked from commit 3bbf3cf)

@dadoonet dadoonet deleted the dadoonet:pr/ingest-attachment-mime4j branch Feb 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.