New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 Repository: Deprecate specifying region #22848

Merged
merged 1 commit into from Jan 29, 2017

Conversation

Projects
None yet
4 participants
@rjernst
Member

rjernst commented Jan 28, 2017

The region and endpoint settings overlap, and have complicated logic for
which to use. Futhermore, region is not necessary, as for most cases it
is automatically figured out by the s3 client, given the bucket name,
and for custom cases like a new region, the endpoint is necessary
anyways. This commit adds a deprecation warning when specifying region.

relates #22758

S3 Repository: Deprecate specifying region
The region and endpoint settings overlap, and have complicated logic for
which to use. Futhermore, region is not necessary, as for most cases it
is automatically figured out by the s3 client, given the bucket name,
and for custom cases like a new region, the endpoint is necessary
anyways. This commit adds a deprecation warning when specifying region.

relates #22758
@abeyad

abeyad approved these changes Jan 28, 2017

LGTM

@dadoonet

LGTM2 :)

@rjernst rjernst merged commit de5ed65 into elastic:5.x Jan 29, 2017

1 check passed

CLA Commit author is a member of Elasticsearch
Details

@rjernst rjernst deleted the rjernst:deprecate_s3_region branch Jan 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment