Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 Repository: Remove region setting #22853

Merged
merged 2 commits into from Jan 30, 2017

Conversation

Projects
None yet
3 participants
@rjernst
Copy link
Member

commented Jan 29, 2017

This change removes the ability to set region for s3 repositories.
Endpoint should be used instead if a custom s3 location needs to be
used.

closes #22758

S3 Repository: Remove region setting
This change removes the ability to set region for s3 repositories.
Endpoint should be used instead if a custom s3 location needs to be
used.

closes #22758
@dadoonet
Copy link
Member

left a comment

It looks good. I just wonder why we added support for s3.client.*.region in the first place.

I believe we should not introduce an already deprecated setting in the first place, no?

@rjernst

This comment has been minimized.

Copy link
Member Author

commented Jan 29, 2017

I just wonder why we added support for s3.client.*.region in the first place.

I was not sure what the feedback would be at the time on removing region, and chose to follow up separately. We could remove it from 5.x, since it has not been released yet.

@dadoonet

This comment has been minimized.

Copy link
Member

commented Jan 29, 2017

I see. Let's remove it then and change the doc then in this PR where we mention it.

@@ -14,3 +14,9 @@ It must exist before the s3 repository is created.
* Support for specifying s3 credentials through environment variables and
system properties has been removed. Use the `elasticsearch-keystore` tool
to securely store the credentials.

* Specifying region has been removed. This includes the settings `cloud.aws.region`,
`cloud.aws.s3.region`, `repositories.s3.region`, `s3.client.*.region` and specifying

This comment has been minimized.

Copy link
@dadoonet

dadoonet Jan 30, 2017

Member

So just remove here

, s3.client.*.region

@rjernst rjernst merged commit cf7747c into elastic:master Jan 30, 2017

1 of 2 checks passed

elasticsearch-ci Build started sha1 is merged.
Details
CLA Commit author is a member of Elasticsearch
Details

@rjernst rjernst deleted the rjernst:remove_s3_region branch Jan 30, 2017

Mpdreamz added a commit to elastic/elasticsearch-net that referenced this pull request Feb 16, 2017

Mpdreamz added a commit to elastic/elasticsearch-net that referenced this pull request Feb 16, 2017

gmarz added a commit to elastic/elasticsearch-net that referenced this pull request Feb 17, 2017

awelburn added a commit to Artesian/elasticsearch-net that referenced this pull request Nov 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.