Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate global `repositories.azure` settings #22856

Merged

Conversation

@dadoonet
Copy link
Member

commented Jan 30, 2017

Today we have multiple ways to define settings when a user needs to create a repository:

  • in elasticsearch.yml file using repositories.azure prefix
  • when creating the repository itself with PUT _snaphot/repo

The plan is to:

  • Deprecate repositories.azure settings in 5.x (this PR)
  • Remove in 6.x (master branch)

Related to #22800

@dadoonet dadoonet self-assigned this Jan 30, 2017

@dadoonet dadoonet requested a review from rjernst Jan 30, 2017

@dadoonet dadoonet referenced this pull request Jan 30, 2017
5 of 6 tasks complete
dadoonet added a commit to dadoonet/elasticsearch that referenced this pull request Jan 30, 2017
Deprecate auto creation of container for azure repository
Similar to elastic#22843 but for azure

Note that we need to add also this information to the deprecation documentation once it will be available (see elastic#22856).
@dadoonet

This comment has been minimized.

Copy link
Member Author

commented Feb 3, 2017

Ping @rjernst

@clintongormley clintongormley added v5.4.0 and removed v5.3.0 labels Feb 7, 2017

@dadoonet

This comment has been minimized.

Copy link
Member Author

commented Feb 17, 2017

@clintongormley So I removed the "deprecation" part in docs with 661ac38 and I will add them back in the breaking change section when I'll port this removal in master branch.

@rjernst I'm planning to merge this PR on Monday if you don't have any objection.

dadoonet added 2 commits Jan 30, 2017
Deprecate global `repositories.azure` settings
Today we have multiple ways to define settings when a user needs to create a repository:

* in `elasticsearch.yml` file using `repositories.azure` prefix
* when creating the repository itself with `PUT _snaphot/repo`

The plan is to:

* Deprecate `repositories.azure` settings in 5.x (this PR)
* Remove in 6.x (master branch)

Related to #22800

Also adds a `deprecated` section in our docs as per #22849.

@dadoonet dadoonet force-pushed the dadoonet:pr/deprecate-repositories-azure-settings branch to 26a2205 Feb 20, 2017

@dadoonet dadoonet merged commit 26a2205 into elastic:5.x Feb 20, 2017

1 check passed

CLA Commit author is a member of Elasticsearch
Details

@dadoonet dadoonet deleted the dadoonet:pr/deprecate-repositories-azure-settings branch Feb 20, 2017

dadoonet added a commit to dadoonet/elasticsearch that referenced this pull request Feb 20, 2017
Remove global `repositories.azure` settings
Today we have multiple ways to define settings when a user needs to create a repository:

* in `elasticsearch.yml` file using `repositories.azure` prefix
* when creating the repository itself with `PUT _snaphot/repo`

The plan is to:

* Deprecate `repositories.azure` settings in 5.x (done with elastic#22856)
* Remove in 6.x (this PR)

Related to elastic#22800
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.