Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name of `enabled_position_increments` #22895

Merged
merged 1 commit into from Feb 3, 2017

Conversation

Projects
None yet
3 participants
@nik9000
Copy link
Contributor

commented Jan 31, 2017

It was accidentally renamed enable_position_increment in the cleanups
for 5.0. This adds enable_position_increment as a deprecated alias
so it will continue to work.

Fix name of `enabled_position_increments`
It was accidentally renamed `enabled_position_increment` in the cleanups
for 5.0. This adds `enable_position_increment` as a deprecated alias
so it will continue to work.
@nik9000

This comment has been minimized.

Copy link
Contributor Author

commented Jan 31, 2017

I opened this against 5.x. My plan is to apply it to 5.x and 5.3 as is and apply it to master without the deprecated name. I'll add docs about it being a breaking change for 6.0 as well.

@abeyad

abeyad approved these changes Feb 3, 2017

Copy link
Contributor

left a comment

LGTM

@nik9000 nik9000 merged commit bca1076 into elastic:5.x Feb 3, 2017

1 check passed

CLA Commit author has signed the CLA
Details
@nik9000

This comment has been minimized.

Copy link
Contributor Author

commented Feb 3, 2017

Thanks for reviewing @abeyad!

master: 70e3cce
5.x: bca1076

There isn't a 5.3 branch anymore so I don't have to merge there. When we make 5.3 we'll fork it from 5.x.

nik9000 added a commit that referenced this pull request Feb 3, 2017

Fix name of `enable_position_increments` (#22895)
It was accidentally renamed `enabled_position_increment` in the cleanups
for 5.0. This adds `enable_position_increment` as a deprecated alias
so it will continue to work.

@nik9000 nik9000 added the >breaking label Feb 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.