Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix def invoked qualified method refs #22918

Merged

Conversation

Projects
None yet
3 participants
@nik9000
Copy link
Contributor

commented Feb 2, 2017

We were incorrectly resolving qualified method references at run
time when invoked on def. This lead to errors like
The struct with name [org] has not been defined. when attempting

doc.date.dates.stream().map(
  org.joda.time.ReadableDateTime::centuryOfEra
).collect(Collectors.toList())
Painless: Fix def invoked qualified method refs
We were incorrectly resolving qualified method references at run
time when invoked on `def`. This lead to errors like
`The struct with name [org] has not been defined.` when attempting

```
doc.date.dates.stream().map(
  org.joda.time.ReadableDateTime::centuryOfEra
).collect(Collectors.toList())
```
@jdconrad
Copy link
Contributor

left a comment

Nice find! Thanks for fixing this.

@nik9000 nik9000 merged commit 73bf290 into elastic:master Feb 2, 2017

1 of 2 checks passed

elasticsearch-ci Build finished.
Details
CLA Commit author has signed the CLA
Details

nik9000 added a commit that referenced this pull request Feb 2, 2017

Painless: Fix def invoked qualified method refs (#22918)
We were incorrectly resolving qualified method references at run
time when invoked on `def`. This lead to errors like
`The struct with name [org] has not been defined.` when attempting

```
doc.date.dates.stream().map(
  org.joda.time.ReadableDateTime::centuryOfEra
).collect(Collectors.toList())
```

nik9000 added a commit that referenced this pull request Feb 2, 2017

Painless: Fix def invoked qualified method refs (#22918)
We were incorrectly resolving qualified method references at run
time when invoked on `def`. This lead to errors like
`The struct with name [org] has not been defined.` when attempting

```
doc.date.dates.stream().map(
  org.joda.time.ReadableDateTime::centuryOfEra
).collect(Collectors.toList())
```
@nik9000

This comment has been minimized.

Copy link
Contributor Author

commented Feb 2, 2017

Thanks for reviewing!

master: 73bf290
5.x: 278b4ae
5.2: 93c2c53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.