Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reindex-from-remote from <2.0 #22931

Merged
merged 1 commit into from Feb 2, 2017

Conversation

Projects
None yet
4 participants
@nik9000
Copy link
Contributor

commented Feb 2, 2017

In 5.2 we stopped sending the source parameter if the user didn't
specify it. This was a mistake as versions before 2.0 look like
they don't always include the _source. This is because reindex
requests some metadata fields. Anyway, now we say "_source": true
if there isn't a _source configured in the reindex request.

Closes #22893

Reindex: fix reindex-from-remote from <2.0
In 5.2 we stopped sending the source parameter if the user didn't
specify it. This was a mistake as versions before 2.0 look like
they don't always include the `_source`. This is because reindex
requests some metadata fields. Anyway, now we say `"_source": true`
if there isn't a `_source` configured in the reindex request.

Closes #22893

@nik9000 nik9000 requested a review from jimczi Feb 2, 2017

@nik9000 nik9000 changed the title Reindex: fix reindex-from-remote from <2.0 Fix reindex-from-remote from <2.0 Feb 2, 2017

@jimczi

jimczi approved these changes Feb 2, 2017

Copy link
Member

left a comment

LGTM

@nik9000 nik9000 merged commit ce8e042 into elastic:master Feb 2, 2017

1 of 2 checks passed

elasticsearch-ci Build finished.
Details
CLA Commit author has signed the CLA
Details
@nik9000

This comment has been minimized.

Copy link
Contributor Author

commented Feb 2, 2017

Thanks for reviewing @jimczi!

master: ce8e042
5.x: 3927cbe
5.2: 0f6bf7e

nik9000 added a commit that referenced this pull request Feb 2, 2017

Reindex: fix reindex-from-remote from <2.0 (#22931)
In 5.2 we stopped sending the source parameter if the user didn't
specify it. This was a mistake as versions before 2.0 look like
they don't always include the `_source`. This is because reindex
requests some metadata fields. Anyway, now we say `"_source": true`
if there isn't a `_source` configured in the reindex request.

Closes #22893

nik9000 added a commit that referenced this pull request Feb 2, 2017

Reindex: fix reindex-from-remote from <2.0 (#22931)
In 5.2 we stopped sending the source parameter if the user didn't
specify it. This was a mistake as versions before 2.0 look like
they don't always include the `_source`. This is because reindex
requests some metadata fields. Anyway, now we say `"_source": true`
if there isn't a `_source` configured in the reindex request.

Closes #22893
@mucika

This comment has been minimized.

Copy link

commented Mar 29, 2017

I just upgraded from 5.2 to 5.3 and tried to reindex from a remote 1.7.6 cluster and the reindexing fails with:

{
"error": {
"root_cause": [
{
"type": "status_exception",
"reason": "body={"error":"ElasticsearchIllegalArgumentException[Failed to decode scrollId]; nested: IOException[Bad Base64 input character decimal 123 in array position 0]; ","status":400}"
}
],
"type": "status_exception",
"reason": "body={"error":"ElasticsearchIllegalArgumentException[Failed to decode scrollId]; nested: IOException[Bad Base64 input character decimal 123 in array position 0]; ","status":400}",
"caused_by": {
"type": "response_exception",
"reason": "POST http://10.56.1.17:9200/_search/scroll?scroll=5m: HTTP/1.1 400 Bad Request\n{"error":"ElasticsearchIllegalArgumentException[Failed to decode scrollId]; nested: IOException[Bad Base64 input character decimal 123 in array position 0]; ","status":400}"
}
},
"status": 400
}

The exact same process/reindex worked fine on 5.2.

@jimczi

This comment has been minimized.

Copy link
Member

commented Mar 29, 2017

Thanks @mucika
I opened #23805 to fix this in 5.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.